On 14 July 2011 09:09, Zhenhua (Gerald) Guo <[email protected]> wrote:
> Right. My committed code does NOT change container.js or > shindig.properties. It only adds a shindig.host system property to > pom.xml. It is enough for basic rendering. But I guess it is not > enough for some other shindig features (without changing container.js > and shindig.properties). > If you want to do something with oauth and secure tokens, you need to override more properties. So the question is, are we going to support overriding a few individual properties _and_ the whole properties file or drop the override of a few individual properties? > So I agree that we will have to change shindig.properties and > container.js eventually. But we still need to figure out how to > change/override them without incurring the burden of maintaining them > in our code base. One idea is to do text filtering for the vanilla > shindig.properties and container.js and replace some placeholders > (e.g. host, port) with the value we want. Host and port are now partially filtered, but the shindig.properties and container.js we get from Shindig 3.0.0-beta2 are not 'clean' enough. Some of the properties don't use the placeholders. In the trunk they have cleaned them up further. Jasha > > Gerald > > On Wed, Jul 13, 2011 at 11:50 PM, Jasha Joachimsthal > <[email protected]> wrote: > > We can also decide to drop the shindig.host & shindig.port system > > properties. You'll have to override the shindig.properties anyway because > > there are some 'hard' configured hostnames inside the shindig.properties > > file. If we keep them, it's better to have an empty system property > because > > if it's not filled in, it will take the value from the shindig.properties > > file. WDYT? > > > > Jasha Joachimsthal > > > > Europe - Amsterdam - Oosteinde 11, 1017 WT Amsterdam - +31(0)20 522 4466 > > US - Boston - 1 Broadway, Cambridge, MA 02142 - +1 877 414 4776 (toll > free) > > > > www.onehippo.com > > > > > > On 14 July 2011 07:34, <[email protected]> wrote: > > > >> Author: zhguo > >> Date: Thu Jul 14 05:34:53 2011 > >> New Revision: 1146563 > >> > >> URL: http://svn.apache.org/viewvc?rev=1146563&view=rev > >> Log: > >> RAVE-98: Start documentation section on website > >> https://issues.apache.org/jira/browse/RAVE-98 > >> > >> RAVE-45: Portal host/ip configuration (Non-localhost support) > >> https://issues.apache.org/jira/browse/RAVE-45 > >> > >> Updated the documentation to include how to modify pom.xml to specify > >> shindig.host. > >> > >> > >> Modified: > >> > >> > > incubator/rave/site/trunk/content/rave/documentation/host-configuration.mdtext > >> > >> Modified: > >> > incubator/rave/site/trunk/content/rave/documentation/host-configuration.mdtext > >> URL: > >> > http://svn.apache.org/viewvc/incubator/rave/site/trunk/content/rave/documentation/host-configuration.mdtext?rev=1146563&r1=1146562&r2=1146563&view=diff > >> > >> > ============================================================================== > >> --- > >> > incubator/rave/site/trunk/content/rave/documentation/host-configuration.mdtext > >> (original) > >> +++ > >> > incubator/rave/site/trunk/content/rave/documentation/host-configuration.mdtext > >> Thu Jul 14 05:34:53 2011 > >> @@ -35,6 +35,7 @@ After a (re)start of Tomcat, the portal > >> ## Override OpenSocial engine configuration > >> The OpenSocial engine (Shindig) has several locations for the host, > port > >> and gadget context path. > >> > >> + * Change setting of `shindig.host` (inside `cargo` container > >> configuration section) in [rave-portal/pom.xml][5] to point to your > host. > >> * Make a copy of [container.js][2] (check if this version is still > valid > >> for your release) > >> * Make a copy of [shindig.properties][3] (check if this version is > still > >> valid for your release) > >> * Change the properties that point to localhost, port 8080 or http > >> @@ -43,9 +44,10 @@ The OpenSocial engine (Shindig) has seve > >> * File system: > >> `shindig.override.properties=/new/location/of/myshindig.properties` > >> * Classpath: > >> `shindig.override.properties=classpath:myshindig.properties` > >> > >> -Note: if the OpenSocial engine still points to localhost, also set a > >> system property `shindig.host` to change the host. > >> > >> [4]: http://localhost:8080/portal > >> [1]: > >> > http://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/resources/portal.properties > >> [2]: > >> > http://svn.apache.org/repos/asf/shindig/tags/shindig-project-3.0.0-beta2/config/container.js > >> -[3]: > >> > http://svn.apache.org/repos/asf/shindig/tags/shindig-project-3.0.0-beta2/java/common/conf/shindig.properties > >> \ No newline at end of file > >> +[3]: > >> > http://svn.apache.org/repos/asf/shindig/tags/shindig-project-3.0.0-beta2/java/common/conf/shindig.properties > >> +[5]: > >> > http://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/pom.xml > >> + > >> > >> > >> > > >
