On 19 July 2011 13:44, Franklin, Matthew B. <[email protected]> wrote:
> > > On 7/19/11 3:29 AM, "Jasha Joachimsthal" <[email protected]> > wrote: > > >I'm still working on storing OAuth information in the database (almost > >done > >now). I see a difference in handling database objects/queries between the > >rave-portal module and the rave-shindig module. > >All rave-portal beans implement o.a.rave.portal.model.BasicEntity while > >all > >rave-shindig beans implement > >o.a.shindig.social.opensocial.jpa.api.DbObject. > >In rave-portal all classes that handle DB queries implement > >o.a.rave.portal.repository.Repository and are configured through Spring. > >The > >Repository implementations extend AbstractJpaRepository which supports at > >simple CRD operations. The Repository implementations have test classes. > >In rave-shindig there seems to be no common interface and injection is > >done > >through Guice (the @Injects are commented out btw). Tests are missing. > > > >Is there someone who has time (and knowledge) to create a common basis for > >database operations in both modules and set up tests for DB operations > >rave-shindig? > > I will update the ticket for adding unit tests to rave-shindig to > replicate the rave-portal JPA pattern to rave-shindig. Probably the > easiest thing to do is create a rave-common project under trunk and start > putting this pattern and any other common code in that project. I can > take this on after I finish canvas/home view toggling. > Thanks :) I'm currently trying to inject the database config for the OAuth persistence through a Guice module in the rave-shindig project (since shindig relies on Guice instead of Spring). I hope to wrap it up before my holiday (end of this week). Jasha
