[
https://issues.apache.org/jira/browse/RAVE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068955#comment-13068955
]
Jesse Ciancetta commented on RAVE-105:
--------------------------------------
I think we might be best to just start fresh with our own implementations
rather than base ourselves on the sample implementations from Shindig (which I
believe is where all of the code we currently in org.apache.shindig.x came
from). I think we've already said that we'd like whatever implementations of
the Shindig SPI's we provide to be architecturally consistent with what we
already have on the Rave side (simple JPA models, service
interfaces/implementations, repository interfaces/implementations, ...) which
means we'd need to make significant changes to what's there already anyway to
achieve that consistency.
So I'm thinking we maybe use the samples from Shindig for reference/inspiration
but go ahead and remove them from our project and start fresh. I also think
once we're done and have something that works well we should offer it back to
the Shindig community to replace the existing sample implementations so that
all we need on the Rave side is a Guice model to bind them at runtime.
Thoughts?
> PersonServiceDb: call addFilterClause with 'special' property adds nothing
> --------------------------------------------------------------------------
>
> Key: RAVE-105
> URL: https://issues.apache.org/jira/browse/RAVE-105
> Project: Rave
> Issue Type: Bug
> Affects Versions: 0.1-INCUBATING
> Reporter: Jasha Joachimsthal
>
> While writing the unit test for PersonServiceDb#addFilterClause I found out
> that
> if (FilterSpecification.isSpecial(filter))
> is true then none of the subclauses can be met (because they try to compare
> different String's to the same variable.
> It then returns 0 as position which means the filter clause will not be added.
> Is this intentional or is it a bug?
> See also PersonServiceDbTest#testAddSpecialFilterClause
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
