What is the correct base dir? This is also something we should mention on the Rave website.
On 16 August 2011 20:04, Raminderjeet Singh <[email protected]>wrote: > Jasha, > > I had the same problem if i selected wrong Base Dir. Hope that is the same > problem you faced. I am using this to review patch for RAVE-148. > > Thank > Raminder > > On Aug 16, 2011, at 4:23 AM, Jasha Joachimsthal wrote: > > > On 15 August 2011 15:05, Ate Douma <[email protected]> wrote: > > > >> On 08/12/2011 04:35 PM, Ate Douma wrote: > >> > >>> On 08/12/2011 01:07 PM, Ciancetta, Jesse E. wrote: > >>> > >>>> A recently submitted patch brought up a few questions that would be > nice > >>>>>>> > >>>>>> to ask in context of the code. It seems to me that we should have a > >>>>> structured way of reviewing and commenting on patches submitted by > the > >>>>> community before application. I know some people have used > >>>>> http://codereview.appspot.com, but does anyone else have experience > >>>>> with > >>>>> public code review tools in open source?\ > >>>>> +1 > >>>>> > >>>>> > >>>>>> How about Crucible - http://www.atlassian.com/**software/crucible/< > http://www.atlassian.com/software/crucible/>, > >>>>>> I am > >>>>>> > >>>>> not sure if ASF only maintains a JIRA or if Crucible is also > available? > >>>>> > >>>>>> > >>>>>> Apache has a reviewboard instance running at: > >>>>> https://reviews.apache.org. > >>>>> See also [1] > >>>>> Many projects ASF projects already are using it, including for > instance > >>>>> Shindig > >>>>> [2]. > >>>>> We only need to request our project to be added at infra by creating > an > >>>>> issue > >>>>> for it. > >>>>> > >>>>> If nobody objects, I could do so later today. > >>>>> > >>>> > >>>> +1 > >>>> > >>>> I've used reviewboard to submit patches to Shindig -- works well and > is > >>>> easy > >>>> to use. > >>>> > >>> > >>> Thanks, good to hear (I haven't reviewboard myself yet). > >>> > >>> I've requested to add Rave to reviewboard: > >>> > >>> https://issues.apache.org/**jira/browse/INFRA-3846< > https://issues.apache.org/jira/browse/INFRA-3846> > >>> > >> > >> Rave group is now added to and available on reviewboard (see above > issue) > > > > > > I tried to upload a patch as new review request but I got the error that > a > > file doesn't exist in the repository (which is true because it is new). > :( > > > > Jasha > >
