I'll start refactoring getId to getEntityId (see https://issues.apache.org/jira/browse/RAVE-260).
Jasha Joachimsthal Europe - Amsterdam - Oosteinde 11, 1017 WT Amsterdam - +31(0)20 522 4466 US - Boston - 1 Broadway, Cambridge, MA 02142 - +1 877 414 4776 (toll free) www.onehippo.com On 14 September 2011 15:17, Franklin, Matthew B. <[email protected]>wrote: > > > >-----Original Message----- > >From: Carlucci, Tony [mailto:[email protected]] > >Sent: Tuesday, September 13, 2011 9:28 AM > >To: [email protected] > >Subject: RE: BasicEntity#getId() is incompatible with some Shindig > interfaces > > > >-----Original Message----- > >From: Ciancetta, Jesse E. [mailto:[email protected]] > >Sent: Tuesday, September 13, 2011 8:34 AM > >To: [email protected] > >Subject: RE: BasicEntity#getId() is incompatible with some Shindig > interfaces > > > >>A few interfaces in the package > org.apache.shindig.social.opensocial.model > >>(e.g. Activity) define a String getId(); Our BasicEntity defines a Long > >>getId(); > >>This means that if we're going to rewrite the current implementations to > use > >>the BasicEntity we have a conflict. This can either be solved to rename > >>BasicEntity#getId or change its return type into java.lang.Object. Any > >>suggestions? > > > >I'd vote to change the name of the BasicEntity#getId -- maybe to > >BasicEntity#getEntityId. > > > >+1 for getEntityId > > +1 > > > > >>Jasha Joachimsthal > >> > >>Europe - Amsterdam - Oosteinde 11, 1017 WT Amsterdam - +31(0)20 522 > >4466 > >>US - Boston - 1 Broadway, Cambridge, MA 02142 - +1 877 414 4776 (toll > free) > >> > >>www.onehippo.com > > > > > >--- > >Anthony Carlucci | SW App Dev Eng, Sr. | R501 / KW App Development & > >Maint > >e: [email protected] | v: 781.271.2432 | f: 781.271.3299 > >The MITRE Corporation | 202 Burlington Rd | Bedford, MA 01730-1420 > >
