----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2338/#review2612 -----------------------------------------------------------
The WidgetRating class is missing in the patch. Can you create a new patch that includes this class (and possibly other classes that don't exist yet)? - Jasha On 2011-10-11 15:32:31, Sean Cooper wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2338/ > ----------------------------------------------------------- > > (Updated 2011-10-11 15:32:31) > > > Review request for rave. > > > Summary > ------- > > Partial Patch which allows users to rate widgets from the detailed widget > view. > > This patch does NOT include a UI to view the user's current rating for a > widget, nor does it include the UI for showing the rating totals for a given > widget. > > Questions for the team > 1) Do we want to add the ability to rate widgets from the widget store > (non-detailed page)? > 2) Do we want to add the ability to rate widgets from the widget menu on a > user's page? > 3) Do we want to include totals of the ratings? (e.g. 314 Liked, 2014 > Disliked) > 3) How should we handle the display of the rating for the user? > a) Iterate over object model to determine user's current rating and totals > - This will result in performance issues when a lot of users have provided > ratings for widgets. > b) Create a statistics service to query the database directly and attach > this statistical information to the object model - This will result in a hard > coded SQL query to gather this information and requires attaching more > information to the web model, as well as requiring mapping the various widget > ratings to the widgets on the UI side. > c) Suggest another approach > > > This addresses bug RAVE-71. > https://issues.apache.org/jira/browse/RAVE-71 > > > Diffs > ----- > > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java > 1181810 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java > 1181810 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java > 1181810 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java > 1181810 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/WidgetServiceTest.java > 1181810 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java > 1181810 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java > 1181810 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java > 1181810 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java > 1181810 > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp > 1181810 > /trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1181810 > > Diff: https://reviews.apache.org/r/2338/diff > > > Testing > ------- > > > Thanks, > > Sean > >
