I finally had a bit more time and looked over a few things in rave and it looks mostly good. I ran a rat:check and fixed the only place where a license header was missed. There are a few places where a META-INF directory is created in src (and it shouldn't) and the MANIFEST.MF fails and one pem test file.
I intend to look while the META-INF is created in src and fix that and add a configuration for the rat plugin in the main pom to exclude the .pem extension. Any ideas, objections? Hadrian On 10/19/2011 08:02 PM, [email protected] wrote:
Author: hadrian Date: Thu Oct 20 00:02:15 2011 New Revision: 1186573 URL: http://svn.apache.org/viewvc?rev=1186573&view=rev Log: Add missing license header Modified: incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/error.jsp Modified: incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/error.jsp URL: http://svn.apache.org/viewvc/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/error.jsp?rev=1186573&r1=1186572&r2=1186573&view=diff ============================================================================== --- incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/error.jsp (original) +++ incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/error.jsp Thu Oct 20 00:02:15 2011 @@ -1,3 +1,21 @@ +<%-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + --%> <%@ page isErrorPage="true" trimDirectiveWhitespaces="true" pageEncoding="UTF-8" contentType="text/html" %> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"; %> <%@ taglib prefix="spring" uri="http://www.springframework.org/tags"; %> @@ -33,4 +51,4 @@ </button> </div> </div> -</rave:rave_generic_page> \ No newline at end of file +</rave:rave_generic_page>
