[
https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134000#comment-13134000
]
[email protected] commented on RAVE-71:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2402/#review2787
-----------------------------------------------------------
Ship it!
Applied your patch with some changes. Iterating over a List of WidgetRatings
per Widget can get very expensive if thousands of users rate a widget so I
created a new repository + service that get the WidgetRating for a specific
widget/user combination.
I saw that the deleteWidgetRating is not in use yet and it's not visible what
the rating of a widget is.
- Jasha
On 2011-10-18 16:57:40, Sean Cooper wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2402/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-18 16:57:40)
bq.
bq.
bq. Review request for rave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added widget ratings to the portal
bq.
bq.
bq. This addresses bug RAVE-71.
bq. https://issues.apache.org/jira/browse/RAVE-71
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java
1185152
bq.
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetRating.java
PRE-CREATION
bq.
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/util/WidgetStatistics.java
PRE-CREATION
bq.
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java
1185152
bq.
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java
1185152
bq.
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java
1185152
bq.
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java
1185152
bq.
trunk/rave-components/rave-core/src/main/resources/META-INF/persistence.xml
1185152
bq.
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetRatingTest.java
PRE-CREATION
bq.
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java
1185152
bq.
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaWidgetRepositoryTest.java
1185152
bq.
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/WidgetServiceTest.java
1185152
bq. trunk/rave-components/rave-core/src/test/resources/test_data.sql 1185152
bq.
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java
1185152
bq.
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java
1185152
bq.
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java
1185152
bq.
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java
1185152
bq.
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java
1185152
bq. trunk/rave-portal-resources/src/main/resources/messages.properties
1185152
bq. trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/store.jsp
1185152
bq. trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp
1185152
bq. trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1185152
bq. trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1185152
bq.
bq. Diff: https://reviews.apache.org/r/2402/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sean
bq.
bq.
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
> Assignee: Jasha Joachimsthal
> Fix For: 0.5-INCUBATING
>
>
> Planning to apply the patch next week
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
