----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2584/#review2888 -----------------------------------------------------------
looks good visually. need to test by applying the patch - Raminder On 2011-10-27 18:44:45, Venkat Mahadevan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2584/ > ----------------------------------------------------------- > > (Updated 2011-10-27 18:44:45) > > > Review request for rave. > > > Summary > ------- > > This is the patch for RAVE-315: WidgetRating - ModelPermissionEvaluator and > Service Annotations > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java > PRE-CREATION > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java > 1189891 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java > 1189891 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java > 1189891 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2584/diff > > > Testing > ------- > > > Thanks, > > Venkat > >
