-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Sure, I can do the commit now.
Marlon On 12/9/11 2:41 PM, Jesse Ciancetta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3078/#review3798 > ----------------------------------------------------------- > > Ship it! > > > LGTM > > Thanks Venkat! > > Marlon -- are you still planning to go ahead and commit? > > - Jesse > > > On 2011-12-09 19:38:25, Venkat Mahadevan wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/3078/ >> ----------------------------------------------------------- >> >> (Updated 2011-12-09 19:38:25) >> >> >> Review request for rave. >> >> >> Summary >> ------- >> >> RAVE-210 Administrators should be able to disable widgets >> >> To disable a gadget, login as Admin and go to "Admin Interface" and to the >> Widgets tab and click on a widget to get its metadata. Here you will find >> two new columns, "Disable Gadget" and "Disable Gadget Message". One can >> disable the gadget from rendering if you check he disable gadget checkbox >> and whatever you put in the message will be displayed on the gadget when the >> gadget is rendered. If you want to enable it, uncheck the checkbox. The >> gadget will be displayed as usual (even if the disable message is still >> there in the metadata, since the checkbox overrides it). >> >> >> Diffs >> ----- >> >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java >> 1212554 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/AbstractContextAwareSingletonBeanDependentTag.java >> 1212554 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java >> 1212554 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties >> 1212554 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties >> 1212554 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgetdetail.jsp >> 1212554 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave.js >> 1212554 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/test/javascript/raveSpec.js >> 1212554 >> >> Diff: https://reviews.apache.org/r/3078/diff >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Venkat >> >> > > -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJO4mSkAAoJEEfVXEODPFIDeWIH/2oxGrgcKI6RF8yW0Rhh/e6M cuCCZ8VKvQgt0Ih5vfBlMHuZhLVsP1hLTFNx+78Q64MoVqfgUtc/FtoBgGikMAIA OlpfI9HLCjmdUVyekoFfrHhUYn4+YHKvfuM76i2D21xFKF6gFpCPvycPNLVDDY/l C8a0jJQR4MygJoJspA2k0mpPdD3hzGC+ZBhe9TVIRNzexZ7ElSYMtgyitkIOV+hy HxzDh1bCdRhMmHSMggsm4wpj7aHv0RQvK5+38HiKjl/VZCmRVQF/GHEiyzFfZy8U 25tOeTjj6LCoGwQKcC0AYniVa6LWuy1rxwMu6A8PW0CovvoasGZESu5nZFaJ52I= =DjpO -----END PGP SIGNATURE-----
