Thanks Tony.
-Venkat -----Original Message----- From: Anthony Carlucci [mailto:[email protected]] Sent: Thursday, December 22, 2011 1:23 PM To: Mahadevan, Venkat; Carlucci, Tony; rave Subject: Re: Review Request: RAVE-69 Widget metadata can be imported into the Widget Repository from Shindig ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3276/#review4083 ----------------------------------------------------------- Ship it! Venkat this looks good. I'm going to make one small change when I apply it - changing getWidgetMetadata in rave_api.js so that it renders a more user-informative error message when the metadata call can't parse an invalid url (such as http://thisisnotawidgeturl.com) - Anthony On 2011-12-22 15:33:52, Venkat Mahadevan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3276/ > ----------------------------------------------------------- > > (Updated 2011-12-22 15:33:52) > > > Review request for rave. > > > Summary > ------- > > RAVE-69 Widget metadata can be imported into the Widget Repository from > Shindig > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetMetadataResolver.java > PRE-CREATION > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/WidgetApi.java > PRE-CREATION > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java > 1221822 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties > 1221822 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties > 1221822 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.jsp > 1221822 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_api.js > 1221822 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/test/javascript/raveApiSpec.js > 1221822 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-providers/rave-opensocial-provider/src/main/java/org/apache/rave/provider/opensocial/service/impl/OpenSocialWidgetMetadataResolver.java > PRE-CREATION > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-providers/rave-opensocial-provider/src/test/java/org/apache/rave/provider/opensocial/service/OpenSocialWidgetMetadataResolverTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3276/diff > > > Testing > ------- > > > Thanks, > > Venkat > >
