On 20 December 2011 21:51, Marlon Pierce <[email protected]> wrote:
> > > > On 2011-12-20 18:51:34, Marlon Pierce wrote: > > > trunk/rave-portal-resources/src/main/webapp/script/rave_store.js, line > 31 > > > <https://reviews.apache.org/r/3012/diff/1/?file=61921#file61921line31> > > > > > > This is still buggy, doesn't work correctly for the 2nd and > subsequent users. > > > > > > If I log in a second time, I will correctly see the saved rating. > However, if I give a +1 to a widget with any negative ratings, the > negative rating will be increased by 1. Similarly, if I give a -1 to a > gadget that already has positive ratings, the positive rating will be > reduced by 1. > > > > > > Instead, these ratings should be persistent. I also assume both + > and - accumulated ratings should be preserved. > > > > > The patch works as intended. The problem is that I am confusing the +/- > buttons with totals, so the total +1/-1 votes for a gadget should not be > displayed on the buttons. The total should be displayed in a third > location, and the buttons should just be labeled +1/-1. > We could visualise it using stars or bullets on a scale from 0-5 (or 10) instead of showing the amounts of -1/+1. > > > - Marlon > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3012/#review4019 > ----------------------------------------------------------- > > > On 2011-12-05 18:38:38, Ankur Goyal wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/3012/ > > ----------------------------------------------------------- > > > > (Updated 2011-12-05 18:38:38) > > > > > > Review request for rave and Marlon Pierce. > > > > > > Summary > > ------- > > > > Corrected the previous patch file. > > Made following changes in rave_store.js:- > > -> changed the "change" function to "click" function > > -> Added one if condition in each click function > > > > > > Diffs > > ----- > > > > trunk/rave-portal-resources/src/main/webapp/script/rave_store.js > 1210544 > > > > Diff: https://reviews.apache.org/r/3012/diff > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Ankur > > > > > >
