----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3358/#review4180 -----------------------------------------------------------
Ship it! - Marlon On 2012-01-03 21:15:27, Ankur Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3358/ > ----------------------------------------------------------- > > (Updated 2012-01-03 21:15:27) > > > Review request for rave and Marlon Pierce. > > > Summary > ------- > > Addressed the following:- > -> removed total votes > -> changed else to else if(!islike) > > prevRating is needed because I used it to check if the current user earlier > selected one option and later changes to a different one. So, in that case, > the previous rating must be decremented. > > Alsp prevRating takes three values -1 (when the current user didn't select > any option), 0 (dislike), 10 (like). So I also needed to check whether it is > the first selection of the current user or not. If it is, then there is no > need to decrement any of the rating. > > > Diffs > ----- > > trunk/rave-portal-resources/src/main/resources/messages.properties 1226929 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp > 1226929 > trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1226929 > trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1226929 > > Diff: https://reviews.apache.org/r/3358/diff > > > Testing > ------- > > > Thanks, > > Ankur > >
