I dug a little further yet and tried removing all of the copy/paste shindig.properties values from rave.shindig.properties and found that three of the properties:
shindig.signing.key-name shindig.signing.key-file shindig.signing.global-callback-url are used to initialize the org.apache.rave.gadgets.oauth.inject.DefaultOAuthStore via Spring property replacement in rave-shindig-applicationContext.xml -- but none of the rest are being used by any Spring components and as I mentioned earlier I don't see anywhere where these values are making it from rave.shindig.properties into any kind of guice context which means (as far as I can tell) they would only be used by Spring components. I was able to delete all of the shindig.properties values from rave.shindig.properties except the three mentioned above and Rave still seemed to run just fine. I also noticed that the three values at the top of the file: shindig.host shindig.port shindig.contextroot don't appear to be in use anywhere either -- so I tried deleting those too and running Rave and everything still seemed fine. So unless anyone objects I'd like to propose that we rename the three shindig.signing.X properties that are currently in use to something else (so that people don't confuse them with the ones already defined in shindig.properties) and remove all of the other properties which don't appear to be in use. Any objections? --Jesse >-----Original Message----- >From: Ciancetta, Jesse E. [mailto:[email protected]] >Sent: Thursday, January 05, 2012 2:11 PM >To: [email protected] >Subject: rave.shindig.properties > >Hi All, > >I'm working on documenting how to get OpenSocial gadgets rendered on >locked-domains using Rave and am running into an issue with the >rave.shindig.properties file. > >That properties file has some custom Rave specific properties defined at the >top, but also has a copy/paste of all of the default properties from the >shindig.properties file at the bottom. The issue I'm running into is that >changing one of those shindig specific properties (shindig.locked- >domain.enabled) doesn't seem to be making its way to shindig at runtime. > >I dug into this a bit and from what I can tell it appears that the copy/paste >of >the shindig.properties probably isn't supposed to actually be there as those >values are never (from what I can see) injected into guice where the shindig >components would then receive them. The rave.shindig.properties file >appears to only be read by the >org.apache.rave.util.OverridablePropertyPlaceholderConfigurer class, and it >appears that classes job is to do some manipulation of the properties read in >and then make them available to the Spring runtime. > >Digging further -- I found that we actually have a custom guice module >(org.apache.rave.commoncontainer.ConfigurablePropertiesModule) which is >responsible for loading the shindig.properties contents from either the >shindig.properties file proper or a custom file/location specified as a system >property (shindig.override.properties). > >So is the copy/paste of all the shindig.properties values into >rave.shindig.properties a carryover from something we were using in the past >and no longer need, or am I just misunderstanding something? > >Thanks! > >--Jesse
