I will take a look at this today. -Matt
From: marijan milicevic <[email protected]<mailto:[email protected]>> Date: Mon, 16 Jan 2012 15:12:50 +0000 To: marijan milicevic <[email protected]<mailto:[email protected]>>, <[email protected]<mailto:[email protected]>>, "[email protected]<mailto:[email protected]>" <[email protected]<mailto:[email protected]>> Subject: Re: Review Request: https://issues.apache.org/jira/browse/RAVE-147 This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3427/ On January 9th, 2012, 5:41 p.m., mfranklin wrote: A couple of notes: 1) I think there is room for consolidation of similar functionality into cohesive units (IE UserService) 2) Your services all use checked exceptions, the rest of Rave uses RuntimeExceptions 3) I would review the model for resetting a password via e-mail. There are a couple of attacks that could be made if you were able to get the forgotPasswordHash vi Man in the middle or other means. Though, these are common in a lot of e-mail reset mechanisms On January 9th, 2012, 7:54 p.m., marijan milicevic wrote: Hi Matt, do you have any suggestions for nr. 3)? bump ;-) Hi Matt, could you review my changes or maybe suggest some other way to implement this, thx. - marijan On January 9th, 2012, 9 p.m., marijan milicevic wrote: Review request for rave. By marijan milicevic. Updated 2012-01-09 21:00:04 Description - configure mail settings to be able to test, see comments in: /rave/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml Diffs * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultNewAccountService.java (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ServiceUtils.java (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/resources/portal.properties (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ChangePasswordController.java (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/NewAccountController.java (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ReminderController.java (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/validator/ChangePasswordValidator.java (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/validator/NewAccountValidator.java (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/validator/NewPasswordValidator.java (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ChangePasswordControllerTest.java (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/UserRepository.java (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaUserRepository.java (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/NewUser.java (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/User.java (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/pom.xml (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-commons/src/main/java/org/apache/rave/exception/EmailException.java (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/pom.xml (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ReminderControllerTest.java (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/portal.properties (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext-security.xml (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/dispatcher-servlet.xml (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/changepassword.jsp (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newpassword.jsp (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/retrieveusername.jsp (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/mailtemplates/password_reminder.ftl (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/mailtemplates/username_reminder.ftl (PRE-CREATION) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/login.jsp (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/pom.xml (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/dist/NOTICE (1229282) * https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/test/resources/portal.properties (1229282) View Diff<https://reviews.apache.org/r/3427/diff/>
