----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3513/#review4483 -----------------------------------------------------------
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java <https://reviews.apache.org/r/3513/#comment10063> By tag search, not free text search. https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java <https://reviews.apache.org/r/3513/#comment10064> Can't you just get this from size of the returned List of widgets? https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java <https://reviews.apache.org/r/3513/#comment10061> Patch needs corresponding modifications to WidgetStoreControllerTest.java https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp <https://reviews.apache.org/r/3513/#comment10059> Although outside this patch, I notice that there is no obvious way to go back to the main store view (you can get there by doing an empty search). I suggest adding a "Widget Store" link to the header when displaying results from either freeform or tag searches. https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp <https://reviews.apache.org/r/3513/#comment10060> I think you may want to display something here even if there are no tagged widgets. Otherwise this becomes a hidden feature that we will overlook. It may also be good to tag some of the widgets in initial_data.sql so that the feature will be usable out of the box. - Marlon On 2012-01-17 12:42:19, jennifer lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3513/ > ----------------------------------------------------------- > > (Updated 2012-01-17 12:42:19) > > > Review request for rave. > > > Summary > ------- > > submit request for rave 72-Users can get Widgets from the Widget Repository > that match a tag > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaWidgetRepositoryTest.java > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp > 1232397 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_store.js > 1232397 > > Diff: https://reviews.apache.org/r/3513/diff > > > Testing > ------- > > > Thanks, > > jennifer > >
