Hi Jasha,

>>  >

>>  > Interesting idea about using a container-supplied system property to
>>  control
>>  > which external file to read the properties from...
>> 
>>  Also, the following seems possible with commons configuration:
>> 
>>    <!-- classpath:portal.xml loaded by spring -->
>>  <configuration>
>>    <override>
>>  <portal>
>>  <opensocial_engine>
>>  <root>localhost:8080</root>
>>  </opensocial_engine>
>>  </portal>
>>  <system/>
>> 
>> 
> <propertiesfileName="${portal.config}/portal-${portal.env}.properties" 
> config-optional="true"/>
>>    </override>
>>  <configuration>
>> 
>> 
>>  So, you can have default properties like portal.opensocial_engine.root,
>>  and those properties can be overriden by optionally provided external
>>  properties file.
>> 
>> 
> Good suggestion Woonsan (as always)! Far better than the properties
> override I once added.
> 


Thanks for the comment!
I have just realized that your OverridablePropertyPlaceholderConfigurer already 
supported properties file path overriding by system property.
But, as you know, when there are multiple properties files for each 
applicationContext, it will be more convenient to use commons-configuration 
because we can reduce system properties.
So, I think I can i) create a JIRA issue for this and ii) add a unit test to 
simulate this concept first for your review. (I don't think we have to rush 
into changing the current solution now.)
Does this sound okay?

Cheers,

Woonsan

Reply via email to