[
https://issues.apache.org/jira/browse/RAVE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195882#comment-13195882
]
Ate Douma commented on RAVE-425:
--------------------------------
I had a brief look at the initial code donations to check if we've done the
required IP Clearance steps [1]...
I'm afraid I have to conclude we haven't, at all!
This is something we (the Mentors) clearly dropped the ball as this is
something we could and should have done right from the beginning.
Even though we decided (from the start) *not* to use any of the initial code
donations but start from scratch, the point of these donations was that it
allows us, now or anytime in the future, to (re)use these again in any form we
consider useful. Which simply means these code donations need to comply to
exactly the same legal rules as any of the other code (or resources) we
maintain on behalf of the project, within the ASF version control system. If we
use and/or release any of this or not doesn't really matter.
As some say: even the svn (root) repository should be considered an 'artifact'
which is the reason we have to maintain a valid and comprehensive NOTICE and
LICENSE file in the svn (trunk) of our project.
So, IMO this means we still need to do the due diligence and review of these
code donations and *fix* them and/or where needed clean them up, to make them
compliant to the ASF license and notice requirements. And if needed, this may
even mean deleting those files/resources which doesn't belong there, as not
being a valid part of the donation and/or which have an incompatible license...
As a start, I've run apache-rat-0.8 against a clean checkout of
https://svn.apache.org/repos/asf/incubator/rave/donations and I've attached the
resulting report (with the dump of the sources without proper headers stripped)
and attached it to this issue.
The summary of this file is:
Summary
-------
Generated at: 2012-01-30T00:32:30+01:00
Notes: 18
Binaries: 636
Archives: 80
Standards: 1564
Apache Licensed: 725
Generated Documents: 0
JavaDocs are generated and so license header is optional
Generated files do not required license headers
839 Unknown Licenses
*******************************
As this report shows, more than 50% of all 'standard' files (839) are *not*
having an compatible license header (or none at all).
Furthermore, there are 80 archives (jars) which we need to reconsider if we
want or need them in here at all.
And, there are some 636 binaries in there as well. Mostly images AFAIK, but for
those too we need to make sure they are appropriate to have in here, e.g.
entitled by the initial donator to donate to the ASF in the first place.
A quick look tells me this doesn't seem the case for quite a few, like a bunch
of images (and .js/.css files) which seem to be coming from ExtJS
(/ogce-gadget-container/ishindig-webapp/src/main/webapp/www/extjs/**).
My personal take on this outstanding task is the following:
a) we (Apache Rave) don't have the intention to use these donation 'as is',
meaning (re)use these in a workable fashion as a whole
b) it is OK to *delete* any and all files from these initial code donations we
cannot or need not determine their appropriate license or copyright for, or
*know* we don't have or will get them
c) each of the donation sources should be provided with a separate and standard
Apache LICENSE and NOTICE file in their root folder
c) for the remaining files missing AL license headers need to be added and
relocate existing copyright headers (from the donator) to the (donation) root
NOTICE file, as well as any other (still) needed NOTICE within the sources
For these tasks the instructions at [2] should be carefully taken into account,
especially concerning providing appropriate svn commit messages as described
there.
Furthermore, I think it is preferably if a representative of each of the
initial donating organizations takes the responsibility to do so (e.g. do the
commit).
If needed I'm willing to help out with this, like creating (partial) patches,
but preferably the commit(s) should be done by a representative of the initial
donators, MITRE, OGCE and SURFNet.
Therefore I'll create 3 new JIRA issues, one for each code donation, and
preliminary assign them. Feel free to re-assign them of course to someone else
within your organization as long as it is an Rave committer :)
Be aware, I suspect this might take considerable time, although not each code
donation is in the same 'shape', and it also depends how much you think
can/should be 'deleted'.
And as this (now) is intended to be ASF code, please consult the PMC first
before making drastic (delete) changes...
I have one more suggestion concerning the SURFNet donation.
As this concerns a full svn import, including history as well as 3 separate
tags and latest trunk, maybe it isn't really important to keep all that around.
I can imagine to only keep that latest trunk donation for Apache Rave, and drop
the older and thus less relevant tags?
That'll reduce the amount of cleanup drastically, without real diminished value
of the code donation.
[1] http://incubator.apache.org/guides/mentor.html#initial-ip-clearance
[2] http://incubator.apache.org/guides/mentor.html#clean-up-best-practice
> Check and make sure for the Rave code donations that the files reflect the
> new ASF copyright
> --------------------------------------------------------------------------------------------
>
> Key: RAVE-425
> URL: https://issues.apache.org/jira/browse/RAVE-425
> Project: Rave
> Issue Type: Sub-task
> Reporter: Ate Douma
> Assignee: Ate Douma
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
