----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4052/#review5398 -----------------------------------------------------------
Ship it! Looks good, I made some changes to the patch which includes the following: - Added CSS to show the featured widgets both in the widget detail page as well as store.jsp. Also removed (featured) from the title - Changed widget.jsp and store.jsp and removed all references to update this field from JpaWidgetReopsitory and WidgetApi - Venkat On 2012-02-27 21:46:14, jennifer lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4052/ > ----------------------------------------------------------- > > (Updated 2012-02-27 21:46:14) > > > Review request for rave. > > > Summary > ------- > > Add featured attribute to the widget object and persist this new attribute to > the database. > Add a check box on the widget detail page to allow admin users to designate > widgets as "featured” > Display featured widgets first on the widget store page > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java > 1294186 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaWidgetRepositoryTest.java > 1294186 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/resources/test_data.sql > 1294186 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java > 1294186 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java > 1294186 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties > 1294186 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties > 1294186 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgetdetail.jsp > 1294274 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp > 1294186 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp > 1294186 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_api.js > 1294186 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_store.js > 1294186 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/test/resources/test-data.sql > 1294186 > > Diff: https://reviews.apache.org/r/4052/diff > > > Testing > ------- > > > Thanks, > > jennifer > >
