Hi Dennis,
On 22 March 2012 22:28, Dennis van der Laan <[email protected]> wrote: > > My first question is that I noticed gadgets which have a 'height' > argument in the gadget moduleprefs, are not resized to that height. The > iframe created for those gadgets have a 'default' height of 250px. I > tried to search for the code where the iframe is created or the height > is set, but I was unable to find it. Can anybody confirm that the height > of the gadget iframe is not resized, based on the 'height' argument in > the ModulePrefs, or is the gadget module incorrect? > > The dynamic-height cannot detect how much height the iframe needs. You should be able to let the iframe content notify the container to resize the iframe with rpc relay calls. As an example the gadget definition in [1] registers the rpc and calls the adjustHeight. The content of the iframe is rendered with [2]. The iframe content does an rpc call to the adjustHeight. As you may see, we've injected the Shindig host there, but at least in the gadget it can be replaced with gadgets.rpc.getOrigin(window.location.href) (haven't checked for the iframe content). [1] https://github.com/OpenConext/OpenConext-teams/blob/master/coin-teams-war/src/main/webapp/WEB-INF/jsp/teams.jsp [2] https://github.com/OpenConext/OpenConext-teams/blob/master/coin-teams-war/src/main/webapp/WEB-INF/tags/genericpage.tag Jasha Joachimsthal Europe - Amsterdam - Oosteinde 11, 1017 WT Amsterdam - +31(0)20 522 4466 US - Boston - 1 Broadway, Cambridge, MA 02142 - +1 877 414 4776 (toll free) www.onehippo.com
