Hi,
Thanks, but I have a few questions...
On Wed, 2007-01-03 at 14:50 +0100, Edouard Gomez wrote:
> Sparse spots quite a few errors in the code:
> - mixing declararyions and code
Should be fixed.
> - make static possible functions
Should also be fixed...
> - declare extern functions that are meant to be extern
What would we gain by doing this? Doesn't all compilers default to
extern for function prototypes?
> - variables shadowing
Should be fixed for clarity...
> This fixes all spotted errors and warnings as of today. I folded the ~10
> patches all together to make it easier to apply, if you want to review
> individual file fixes, ask for the series instead of the folded patch.
It took quite some time to skim thou, but it was worth it :)
> +++ b/src/gtk-helper.c Wed Jan 03 14:24:23 2007 +0100
> @@ -35,7 +35,7 @@ static void gui_cms_di_profile_button_cl
> static void gui_cms_di_profile_button_clicked(GtkButton *button, gpointer
> user_data);
> static void gui_cms_ex_profile_button_clicked(GtkButton *button, gpointer
> user_data);
>
> -gchar *color_profiles[] = {
> +static gchar *color_profiles[] = {
Shouldn't this be const'ed too?
/abrander
_______________________________________________
Rawstudio-dev mailing list
[email protected]
http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev
