Hi there, I just started using rawstudio recently with my new Pentax k20d. I was quite happy with it, until I noticed that the exported images looked very dull compared to the preview. In fact, they looked exactly like the difference between using dcraw 8.83 and 8.84. The changelog for dcraw mentioned updating some adobe matrices, so armed with that limited clue I dove into the rawstudio code.
It actually was pretty simple: rawstudio.c calls rs_color_transform_set_adobe_matrix after rs_color_transform_set_from_settings, whereas rs-preview-widget.c calls it before. The attached patch corrects the ordering in rawstudio.c, and now I get exports that look as they should. Thanks, Matt
Index: src/rawstudio.c =================================================================== --- src/rawstudio.c (revision 1858) +++ src/rawstudio.c (working copy) @@ -511,10 +511,10 @@ /* Initialize color transform */ rct = rs_color_transform_new(); + rs_color_transform_set_adobe_matrix(rct, &photo->metadata->adobe_coeff); rs_color_transform_set_from_settings(rct, photo->settings[snapshot], MASK_ALL); rs_color_transform_set_output_format(rct, 8); rs_color_transform_set_cms_transform(rct, transform); - rs_color_transform_set_adobe_matrix(rct, &photo->metadata->adobe_coeff); /* actually save */ switch (filetype)
_______________________________________________ Rawstudio-dev mailing list [email protected] http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev
