Hi, Sorry for the slow response.
On Fri, 2008-12-05 at 04:23 +0100, Ille wrote: > > > By the way, I think there is a bug when opening x3f files which do > > > NOT need demosaic. Those are actually opened at double size, > > > causing the preview to be a little bit blurry... I join a patch to > > > correct this behaviour. The patch also take care of the > > > auto-rotation of the x3f thumbnail and image. > > Oh that was a nasty bug! Are you sure that filters and > > fourColorFilters are valid with this fix? > Well, as far as I can understand, I think yes. Because the only thing I > did is store the is_foveon flag from dcraw and if this flag is set, > always call rs_image16_open_dcraw_apply_black_and_shift_half_size in > rs_image16_open_dcraw. Nothing else. I have fixed this in trunk revision 2172 the "proper" way. (See plugins/demosaic and plugins/load-dcraw if you're interested) > > Regarding rotation in X3F-images, are you sure the rotation works as > > expected? Will the loaded image (and not just the thumbnail) be > > rotated as expected? > I did not notice any trouble with the auto-rotation. When reading the > metadata, I just set meta->orientation to the right value, as I think > metadata are also read when the file gets open, and not just when > 'thumbnailing'... Ok. I have applied your rotation patch to trunk revision 2173. Thanks! /abrander _______________________________________________ Rawstudio-dev mailing list [email protected] http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev
