On Mon, Oct 14, 2002 at 07:28:06PM +0100, [EMAIL PROTECTED] wrote:
> I have just completed an experimental integration of razor into an MTA (of
> my own design) that I am working on.
> 
> I haven't initially been getting anything like the performance I was
> expecting, and I have been doing some digging around to try and understand
> why not. The first thing I noticed was that only 'text' SPAMs were getting
> correctly identified.  I then ran some examples by hand, and noticed that
> though MIME separators were getting correctly identified, no MIME blocks
> were getting processed.
> 
> After some scratching of the head (I'm not a perl programmer) I came to the
> conclusion that one of the main culprits is in String.pm, line 835:
> 
> my @tmpparts = split /\n\Q--$boundary\E\n/, $body;
> 
> Certainly a lot of the mail that comes through my system contain "\r\n" at
> the end of lines. So, wouldn't
> 
> my @tmpparts = split /\n\Q--$boundary\E\r*\n/, $body;
> 
> be a safer option?  I tried it and it certainly improved the parsing up to a
> point

You are right. \r\n is converted to \n in prep_part() but before that
stage, the code should take \r's into consideration. I've modified this,
and a couple of lines later in (my @tmpparts = split
/\n\Q--$boundary\E\r*\n/, $body;) Will introduce this in the next release.
Let me know if you notice anything else...

cheers,
vipul.


-- 

Vipul Ved Prakash          |   "The future is here, it's just not 
Software Design Artist     |    widely distributed yet."
http://vipul.net/          |              -- William Gibson



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Razor-users mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/razor-users

Reply via email to