On 4 July 2013 at 12:43, Romain Francois wrote: | Thanks. This seems like a good idea. And kudos for updating unit tests as well. | | I'll apply this later if nobody else is faster.
Well you and I are both travelling so this may need a few more days -- but let me add a second 'Thank You' to Ben. We do appreciate the patch, and all your previous contributions. Cheers, Dirk | Romain | | Le 4 juil. 2013 à 12:24, QRD <q...@sig.com> a écrit : | | > Hi, | > | > Would you consider adding a convenience overload | > | > bool containsElementNamed( const std::string & target ) const; | > | > to the Rcpp::Vector class? The attached patch does this, chaining | > down to the existing (const char *) method. It also updates the | > unit test to check both overloads. Against 0.10.4. | > | > Thanks, | > | > Ben. | > | > <string-overload-containsElementNamed.patch> | > _______________________________________________ | > Rcpp-devel mailing list | > Rcpp-devel@lists.r-forge.r-project.org | > https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/rcpp-devel | _______________________________________________ | Rcpp-devel mailing list | Rcpp-devel@lists.r-forge.r-project.org | https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/rcpp-devel -- Dirk Eddelbuettel | e...@debian.org | http://dirk.eddelbuettel.com _______________________________________________ Rcpp-devel mailing list Rcpp-devel@lists.r-forge.r-project.org https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/rcpp-devel
