On Mon, Mar 25, 2024 at 05:41:22PM +0100, Johannes Berg wrote: > Also __acquire()/__release() are just empty macros without __CHECKER__. > So not sure the indirection really is warranted for this special case. > > I can add a comment in there, I guess, something like > > /* sparse doesn't actually "call" cleanup functions */ > > perhaps. That reminds me I forgot to CC Dan ... >
These are Sparse warnings, not Smatch warning... Smatch doesn't use any of the Sparse locking annotations. Smatch handles cleanup basically correctly at this point. regards, dan carpenter
