On Thu, Jan 02, 2025 at 01:41:16PM +0800, Oliver Sang wrote:
> hi, Zqiang, hi, Paul,
>
> On Tue, Dec 31, 2024 at 08:19:44AM -0800, Paul E. McKenney wrote:
> > On Tue, Dec 31, 2024 at 03:16:25PM +0800, Z qiang wrote:
>
> [...]
>
> > > >
> > > > If you fix the issue in a separate patch/commit (i.e. not just a new
> > > > version of
> > > > the same patch/commit), kindly add following tags
> > > > | Reported-by: kernel test robot <oliver.s...@intel.com>
> > > > | Closes:
> > > > https://lore.kernel.org/oe-lkp/202412311203.ca7bddba-...@intel.com
> > > >
> > >
> > > Please try the following modifications:
>
> yes, the following modifications fix the issues we found for 9216c28c6a.
> thanks!
>
> Tested-by: kernel test robot <oliver.s...@intel.com>
Thank you, and I will apply this during my next rebase.
Zqiang, unless you tell me otherwise, I will add your Co-developed-by
and Signed-off-by.
Either way, Happy Square New Year!
Thanx, Paul
> > > diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> > > index e85db7d5b364..7c7304dee645 100644
> > > --- a/kernel/rcu/srcutree.c
> > > +++ b/kernel/rcu/srcutree.c
> > > @@ -1999,6 +1999,7 @@ static int srcu_module_coming(struct module *mod)
> > > for (i = 0; i < mod->num_srcu_structs; i++) {
> > > ssp = *(sspp++);
> > > ssp->sda = alloc_percpu(struct srcu_data);
> > > + ssp->srcu_ctrp = &ssp->sda->srcu_ctrs[0];
> >
> > This does look quite promising, so thank you for digging into this!!!
> >
> > Looking forward to seeing if it fixes the problem. ;-)
> >
> > Thanx, Paul
> >
> > > if (WARN_ON_ONCE(!ssp->sda))
> > > return -ENOMEM;
> > > }
> > >
> > >
> > >
> > > Thanks
> > > Zqiang
