Hi Greg, Let's continue this conversation at https://github.com/rdkit/rdkit/pull/3474 :)
On Tue, 6 Oct 2020 at 19:38, Greg Landrum <greg.land...@gmail.com> wrote: > Jin, > > On Tue, Oct 6, 2020 at 10:01 PM Jin Pan <jin....@postera.ai> wrote: > >> >> I can take a look at removing the mutex and testing. >> > > That would be great, thanks! > > >> It looks like there's already `testMultiThread` in >> `External/INCHI-API/test.cpp` which covers most of the functions with the >> exception of `MolBlockToInchi`. Do you think it is sufficient to add >> coverage for `MolBlockToInchi` and enable `testMultiThread` (s/#if 0/#if 1 >> in main())?. >> > > Ah, look at that... I had forgotten that code is even there. Looks like > the testing is easy. :-) > The existing tests look like a good starting point. Adding something to > also test MolBlockToInchI in multi-threaded mode is also a good idea. > > FYI: it looks like most of the current tests are #if 0'ed out in > `External/INCHI-API/test.cpp`; that's a mistake I made that didn't get > caught in the review of one of my PRs. I'm going to fix that now. > > Also, how can we run the tests with asan/msan/tsan and friends? >> > > hmm, I don't understand the question. > > -greg >
_______________________________________________ Rdkit-discuss mailing list Rdkit-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rdkit-discuss
