Thank you for the question and patch. On Fri, May 2, 2008 at 1:58 PM, Michael Stahl <[EMAIL PROTECTED]> wrote: > so, i noticed that librdf_stream_get_context returns a void*... why?
I don't really know. I'd guess it comes from the fact that the underlying stream callback get_method returns a void* as it will return librdf_statement* or librdf_node*, depending on the flags passed in. That makes it easy to use void*s internally and transfer the burden of type casting to caller. librdf_stream inherits its core design from librdf_iterator. According to svn logs, latest significant changes to that design are from 2002. > imho it should return librdf_node* instead. > patch is attached. Agree, returing librdf_node* makes sense. However, it would introduce a slight API break and would not bring much benefit as such. I'd like to hear dajobe's take on this issue. The patch itself is not sufficient: - prototypes in rdf_stream.h are not changed - should keep rdf_stream consistent with rdf_iterator -> patch rdf_iterator.[ch] as well Lauri _______________________________________________ redland-dev mailing list [email protected] http://lists.librdf.org/mailman/listinfo/redland-dev
