Is the change big? If not I'd rather get this in .. getting a 401 for
a missing resource is not good.
It is not a big change :)
If you think its ok to do the changes then we can merge the changes.
Thanks
Deepal
Sanjiva.
Deepal Jayasinghe wrote:
Chathura/Deepal:
I just checked in a change to trunk which fixes what I think is a
major bug. Before this fix if I access a non-existent resource via
HTTP, the registry would return a 401 Unauthorized response. In a
browser, this would result in a login popup.
After the fix (which is to check resourceExists() in SecureRegistry
before checking authorization) we get a 404 as expected.
Great.
I'll leave it to you guys to decide whether or not to merge this to
the branch - I think it should be merged in and released with 1.0,
so +1 from me.
I too agree since you have done a very good fix , however I am bit
worried about doing last minute changes since we have done a number
of QA round , and we decided not do last minute changes. So I am 0-
on this.
Thanks
Deepal
Please discuss and merge after taking a look if you agree.
I'll be back online in 6 or 7 hours - gotta sleep for a bit!
Thanks,
--Glen
_______________________________________________
Registry-dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/registry-dev
_______________________________________________
Registry-dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/registry-dev
_______________________________________________
Registry-dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/registry-dev
