Just to be sure, I checked and it's easy to see if a merge proposal is
self-reviewed:
>>> from launchpadlib import launchpad
>>> root = launchpad.Launchpad.login_with(...)
>>> branch = root.branches.getByUrl(url='...')
>>> merge_proposal = branch.landing_targets[0]
>>> votes = merge_proposal.votes[:2]
>>> self_reviewed = (
... len(votes) == 1 and votes[0].reviewer == branch.owner)
** Description changed:
The "Activities" section in:
- https://dev.launchpad.net/PolicyAndProcess/OptionalReviews
+ https://dev.launchpad.net/PolicyAndProcess/OptionalReviews
instructs us to self-review by approving merge proposals with the
"unreviewed" type. However, ec2 land does not count these type of
reviews. Upon inspection, neither does bzr lp-land.
For now it is sufficient to self review without a type (agreed with
- jml and lifeless). For stats, it needs to be possible to determine
- that a proposal is self-reviewed; this has yet to be checked.
+ jml and lifeless). For stats, it is still possible to determine
+ that a proposal is self-reviewed.
--
ec2 land and bzr lp-land should recognize "unreviewed" review types
https://bugs.launchpad.net/bugs/669936
You received this bug notification because you are a member of Bzr-pqm-
devel, which is the registrant for Bazaar PQM Plugin.
_______________________________________________
Mailing list: https://launchpad.net/~registry
Post to : [email protected]
Unsubscribe : https://launchpad.net/~registry
More help : https://help.launchpad.net/ListHelp
