Jan Kara <[EMAIL PROTECTED]> wrote:
>
> > 
> > What prevents vfs_quota_off() from racing with unmount?
> > 
> > If you look at, say, sync_filesystems() you'll see that we take ->s_umount
> > and then test ->s_root to check that we didn't race with an unmount
> > attempt.
>   I thought that the sync_fs and stuff is guarded by the fact that quota
> code is holding references to inodes on the filesystem. And invalidate_bdev()
> should not care about the filesystem. Or do I miss something? Anyway
> adding a comment about this is really a good idea...

Holding a ref on an inode will not cause umount to block.  It'll just cause
nasty "Busy inodes after unmount" warnings.


Reply via email to