On Tue, Feb 15, 2005 at 04:37:29PM -0500, Tom Evans wrote:
>
> >do you see aligment faults in the bitmap code after my patch?
>
> The patch that was presented a few days ago caused corruption of the volume.
> I used a "patch" I did that simply used the unaligned macros.
did you apply the patch (see below) which i sent to amd64 guys?
--------------------------------------------------
diff -Nru a/plugin/space/bitmap.c b/plugin/space/bitmap.c
--- a/plugin/space/bitmap.c Wed Feb 16 07:53:36 2005
+++ b/plugin/space/bitmap.c Wed Feb 16 07:53:36 2005
@@ -165,7 +165,7 @@
static int
find_next_zero_bit_in_word(ulong_t word, int start_bit)
{
- ulong_t mask = 1 << start_bit;
+ ulong_t mask = 1UL << start_bit;
int i = start_bit;
while ((word & mask) != 0) {
@@ -235,7 +235,7 @@
assert ("zam-965", start_bit < BITS_PER_LONG);
assert ("zam-966", start_bit >= 0);
- bit_mask = (1 << nr);
+ bit_mask = (1UL << nr);
while (bit_mask != 0) {
if (bit_mask & word)
--------------------------------------------------
>
> I will try the new patch this evening.
>
> Thanks,
>
> ...tom
>
--
Alex.
