Wiktor Wandachowicz wrote:
<jp.guillemin <at> free.fr> writes:
I think the idea is "basically" great , and I would like to see such a feature
in reiser3 & reiser4...
Just IMHO ;)
JP
Well, I've checked the source and actually all the needed data were already in
place. I mean: the reiserfs_super_block structure contains the needed s_label
field. So I've changed a bit one source file and voila! Now the volume label is
shown exactly as I would like it to see.
The whole point is to change the print_super_block function in the
reiserfscore/prints.c file, as following:
=== QUOTE BEGIN ===
/* return 1 if this is not super block */
int print_super_block (FILE * fp, reiserfs_filsys_t * fs, char * file_name,
struct buffer_head * bh, int short_print)
{
struct reiserfs_super_block * sb =
(struct reiserfs_super_block *)(bh->b_data);
dev_t rdev;
int format = 0;
__u16 state;
if (!does_look_like_super_block (sb))
return 1;
rdev = misc_device_rdev(file_name);
/* Print volume label if it is non-empty. */
if (sb->s_label[0]) {
reiserfs_warning (fp, "%s: ", sb->s_label);
}
reiserfs_warning (fp, "Reiserfs super block in block %lu on 0x%x of ",
bh->b_blocknr, rdev);
switch (get_reiserfs_format (sb)) {
=== QUOTE END ===
For reiserfs-3.6.19, .18 & .17 I just needed to add the following test
(I don't have older versions, but I suppose it's also applicable):
/* Print volume label if it is non-empty. */
if (sb->s_label[0]) {
reiserfs_warning (fp, "%s: ", sb->s_label);
}
I think I'll send that as a patch to the Namesys, like they say on their
website: http://namesys.com/code.html, with all the needed legal mambo-jumbo
from: http://namesys.com/legalese.html
Vote for this feature enhancement and maybe they will incorporate it mainstream.
IMHO it's quick, easy, sane and adds some value at the same time.
I can't say if the same is possible for ReiserFS v.4 because I don't use it.
Friendly,
Wiktor
I've found this method in Reiser4 sources
reiser4_master_get_label(fs->master)
And I am assuming this function from libreiser4/master.c
/* Reads master super block from disk */
reiser4_master_t *reiser4_master_open(aal_device_t *device) {
would be where to call the reiser4_master_get_label method...I'll try to
modify the code and see if my assumptions are correct.
Yiannis.
______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email
______________________________________________________________________
