> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Jan Kara wrote:
> >> The data journaling mode can be set as a flag associated with the inode.
> >> Currently, i_data_log is set in REISERFS_I(inode)->i_flags. I add
> >> i_data_ordered in one of my later patches. They can be tested easily
> >> with reiserfs_file_data_{log,ordered}. There's no reason that one
> >> couldn't be moved up and made a prerequisite for the first patch.
> > Fine. So we can just set proper journaling flags in reiserfs_quota_on
> > and then honor them in the internal writing functions.
>
> Ok, how do the attached patches look to you? The internal I/O changes
> need to be applied after the journaled xattr patch or we get an Oops
> trying to start a transaction without calling reiserfs_write_lock()
> first. I've modified the first patch in the xattr series to abstract out
> the fp->f_op->{read,write} calls to an xattr_{read,write} pair of
> functions. This makes it easier to move to the internal i/o code later.
> I've included it for clarity, but that is the only change.
The patch looks fine. Just two minor comments:
<snip>
> diff -ruNpX ../dontdiff linux-2.6.15-staging1/fs/reiserfs/super.c
> linux-2.6.15-staging2/fs/reiserfs/super.c
> --- linux-2.6.15-staging1/fs/reiserfs/super.c 2006-03-03 17:09:01.000000000
> -0500
> +++ linux-2.6.15-staging2/fs/reiserfs/super.c 2006-03-03 17:09:04.000000000
> -0500
> @@ -1949,6 +1949,109 @@ static int reiserfs_statfs(struct super_
> return 0;
> }
>
> +#if defined(CONFIG_QUOTA) || defined(CONFIG_REISERFS_FS_XATTR)
> +/* Read data from quotafile - avoid pagecache and such because we cannot
> afford
> + * acquiring the locks... As quota files are never truncated and quota code
> + * itself serializes the operations (and noone else should touch the files)
> + * we don't have to be afraid of races */
Update here the comment to reflect that we use this function also for
xattrs now - I suppose those files cannot be truncated either and that
xattr code serializes the operations there.
> +ssize_t reiserfs_internal_read(struct inode *inode, char *data, size_t len,
> + loff_t off)
<snip>
> +/* Write to quotafile (we know the transaction is already started and has
> + * enough credits) */
Here again update the comment...
> +ssize_t reiserfs_internal_write(struct inode *inode, const char *data,
> + size_t len, loff_t off)
Honza
--
Jan Kara <[EMAIL PROTECTED]>
SuSE CR Labs
