-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Eric Sesterhenn wrote:
> hi,
>
> coverity complained that xadir is checked for !=NULL
> and then passed to lookup_one_len() where it might get dereferenced.
> This patch removes the check since open_xa_dir() returns an ERR_PTR() or
> a valid dentry pointer. Coverity id #1194
>
> Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]>
>
> --- linux-2.6.17-rc5/fs/reiserfs/xattr.c.orig 2006-06-13 23:50:10.000000000
> +0200
> +++ linux-2.6.17-rc5/fs/reiserfs/xattr.c 2006-06-13 23:50:45.000000000
> +0200
> @@ -200,7 +200,7 @@ static struct dentry *get_xa_file_dentry
> xadir = open_xa_dir(inode, flags);
> if (IS_ERR(xadir)) {
> return ERR_PTR(PTR_ERR(xadir));
> - } else if (xadir && !xadir->d_inode) {
> + } else if (!xadir->d_inode) {
> dput(xadir);
> return ERR_PTR(-ENODATA);
> }
>
>
Looks ok to me.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFEkB+bLPWxlyuTD7IRAnacAKCO/x/4GvVwktuyaOqbGPGEQujNaQCgkTlV
RDm+IISOQgNzGRJ/ynvEHQU=
=dDQr
-----END PGP SIGNATURE-----
