Hans Reiser wrote:
Jeff Mahoney wrote:+ reiserfs_error(s, "vs-4020", "bitmap block " + "%lu(%u) can't be freed or reused", + block, SB_BMAP_NR(s)); return 0; }get_bit_address(s, block, &i, &j); if (i >= SB_BMAP_NR(s)) { - reiserfs_warning(s, "vs-4030", "there is no so many "Jeff, as a native english speaker, can you review the english and informativeness of these?- "bitmap blocks: block=%lu, bitmap_nr=%d", - block, i); + reiserfs_error(s, "vs-4030", "there is no so many " + "bitmap blocks: block=%lu, bitmap_nr=%d", + block, i); return 0; }
At some point, sure, but I'd rather it be a separate patch. This one is just focused on the warning/panic->error conversion. At some point a reiserfs-proper-english.diff might not be a bad idea.
-Jeff -- Jeff Mahoney SUSE Labs
