On Thursday 29 June 2006 21:36, Hisashi Hifumi wrote: > Hi, > > At 09:47 06/06/30, Chris Mason wrote: > >Thanks for the patch. One problem is this will bump the transaction > > marker for atime updates too. I'd rather see the change done inside > >reiserfs_file_write. > > I did not realize that an atime updates is also influenced. > > >reiserfs_file_write already updates the transaction when blocks are > > allocated, but you're right that to be 100% correct we should cover the > > case when i_size increases but new blocks are not added. Was this the > > case you were trying to fix? > > Yes, that's right. > > So, I remade my patch as follows. > I tested this patch and confirmed that the kernel with this patch work > well.
This is correct, excpet you need to put the update_inode_transaction call inside reiserfs_write_lock/unlock. -chris
