Hello rekonq guys,
I really like what I'm seeing with rekonq. So much that I decided to write a
patch to polish a few things up. ;-) Hopefully they can be included in
mainline rekonq.
I've attached the patch, which has several improvements to make rekonq's main
configuration dialog more like those of other KDE applications. First, it uses
the regular KPageDialog interface rather than the tree view. The treeview
doesn't really make sense because there isn't really a tree. All config pages
are top-level and there are no child objects. Most other KDE apps' config
dialogs work similarly, with Kate and Konqueror being the main exceptions. I
also set showButtonSeparator to false, in line with other KDE applications.
To accommodate for the extra space I bumped up the dialog height to 525 px,
which is still safe enough away from the currently-golden 576 magical pixel
limit for netbooks. ;-)
The last change was changing the window title from "rekonfig..." to "Configure
- rekonq". I made this change for several reasons:
* It is more in line with other KDE applications
* rekonfig, while undeniably cute, is a bit unprofessional looking.
* The "..." after rekonfig doesn't really fit there. The "..." is usually
reserved for buttons or other GUI items that launch other dialogs when
clicked.
I do have a similar opinion for the use of the lowercase "rekonq" throughout
the GUI, though I don't know how willing you all would be to change that. ;-)
I think it would be good to change "rekonq" to "Rekonq" throughout the GUI to
come across as more serious/professional.
Hopefully we can come to an agreement on these changes, because I noticed that
a few of the things I had changed were deliberately put there. I have included
this patch aside from the config dialog string change (since that would be bad
for future translations) for the packages for the development version Kubuntu
10.04.
Thanks and keep up the good work,
Jonathan Thomas
diff -Nru rekonq-0.2.90-orig/src/settings.cpp rekonq-0.2.90/src/settings.cpp
--- rekonq-0.2.90-orig/src/settings.cpp 2009-10-27 20:25:37.000000000 -0400
+++ rekonq-0.2.90/src/settings.cpp 2009-10-28 18:10:46.000000000 -0400
@@ -128,7 +128,7 @@
pageItem = parent->addPage(ebrowsingModule, i18n(ebrowsingInfo.moduleName().toLocal8Bit()));
pageItem->setIcon(KIcon(ebrowsingInfo.icon()));
- parent->setMinimumSize(700,500);
+ parent->setMinimumSize(700,525);
}
@@ -139,25 +139,23 @@
: KConfigDialog(parent, "rekonfig", ReKonfig::self())
, d(new Private(this))
{
- setFaceType(KPageDialog::Tree);
- showButtonSeparator(true);
+ showButtonSeparator(false);
- setWindowTitle(i18n("rekonfig..."));
+ setWindowTitle(i18n("Configure - rekonq"));
setModal(true);
readConfig();
-
connect(d->generalUi.setHomeToCurrentPageButton, SIGNAL(clicked()), this, SLOT(setHomeToCurrentPage()));
-
+
connect(d->ebrowsingModule, SIGNAL(changed(bool)), this, SLOT(updateButtons()));
connect(d->cookiesModule, SIGNAL(changed(bool)), this, SLOT(updateButtons()));
connect(d->proxyModule, SIGNAL(changed(bool)), this, SLOT(updateButtons()));
connect(d->shortcutsEditor, SIGNAL(keyChange()), this, SLOT(updateButtons()));
-
+
connect(this, SIGNAL(applyClicked()), this, SLOT(saveSettings()));
connect(this, SIGNAL(okClicked()), this, SLOT(saveSettings()));
-
+
setWebSettingsToolTips();
}
_______________________________________________
rekonq mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/rekonq
