KDE HIG says that we should use descriptive buttons when the user must
choose between two actions. Therefore Continue/Cancel is fine here.
See
http://techbase.kde.org/Projects/Usability/HIG/Messages#Confirmation_Button_Labels
The attached patch is independent from the first one and changes the
dialog style to warningContinueCancel.
Maybe the warning style is even more appropriate in this case.
Markus schrieb:
Am Montag 11 Januar 2010 23:23:16 schrieb Ronny Scholz:
We could use a the prebuilt warningContinueCancel dialog.
Does is only display Continue/Cancel? Somewhere in the KDE Human Interface
Guidelines it's written that button labels should be descriptive.
_______________________________________________
rekonq mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/rekonq
diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
index 9352ec3..aef3830 100644
--- a/src/mainwindow.cpp
+++ b/src/mainwindow.cpp
@@ -715,8 +715,8 @@ void MainWindow::privateBrowsing(bool enable)
" Until you close the window, you can still click the Back and Forward buttons"
" to return to the web pages you have opened.</p>", title);
- int button = KMessageBox::questionYesNo(this, text, title);
- if (button == KMessageBox::Yes)
+ int button = KMessageBox::warningContinueCancel(this, text, title);
+ if (button == KMessageBox::Continue)
{
settings->setAttribute(QWebSettings::PrivateBrowsingEnabled, true);
m_view->urlBar()->setBackgroundColor(Qt::lightGray); // palette().color(QPalette::Active, QPalette::Background));
_______________________________________________
rekonq mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/rekonq
