Hi,
even with the two lasting deleteLater() I got crashes.
Attached the patch....probably not necessary ;-)
I filed a bugreport for QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=37855
Regards,
Johannes
On Tuesday 20 April 2010 15:49:21 Johannes Zellner wrote:
> Hi,
>
> attached a fix, that reverts one line of commit
> http://gitorious.org/rekonq/mainline/commit/2fc4da5614113a8a184f6bdd05185cc
> 875d9ce27
>
> Usually the reply should be cleaned up as it is done with this commit, but
> it seems the reply is used afterwards within Webkit.
> The Qt demo browser does also no cleanup in the SLOT connected to the
> "finished()" signal.
>
> I will also file a bug in webkit, to clarify who and when the reply should
> be cleaned up.
>
> Regards,
> Johannes
diff --git a/src/webpage.cpp b/src/webpage.cpp
index 2b2957f..b310428 100644
--- a/src/webpage.cpp
+++ b/src/webpage.cpp
@@ -267,7 +267,7 @@ void WebPage::handleUnsupportedContent(QNetworkReply *reply)
return;
case KParts::BrowserOpenOrSaveQuestion::Cancel:
- return reply->deleteLater();
+ return;
default: // non extant case
break;
@@ -375,7 +375,6 @@ void WebPage::manageNetworkErrors(QNetworkReply *reply)
}
- reply->deleteLater();
}
_______________________________________________
rekonq mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/rekonq
