Hi Mathias, That looks like a good patch to me. A few minor annoyances
At lines 10, 125, 138, could you please put each argument on a separate line rather than extending the line so much. line 218, please add a comment explaining why you are removing the slash. And could you give a high level overview of what you mean by "UrlResolver::privilegedItem it wasn't needed anyway and I found a good workaround for that". That would make a good commit message to so that someone looking at the code could get a good idea of why it is the way it is. Regards, Nikhil On 6/4/10, Mathias Kraus <[email protected]> wrote: > hi, > > I'm affected with bug #237390 [1], so I decided to have a look at it. > attached is a bookmark file with 10000 entries. if you use it with the > current > rekonq, don't type anything in the urlbar. it will freeze and take very long > to respond again. > with the attached patch, you get almost immediately the completion list. > basically I extendet UrlSearchItem and replaced the KUrl with a QString, > because that had a negative effect to performance. beside > UrlResolver::privilegedItem it wasn't needed anyway and I found a good > workaround for that. the completion now also works for titles, not only for > urls. > at the moment the startup speed is negatively affected with many bookmarks, > but as rekonq is unusable with that many bookmarks, this shouldn't matter at > the moment. I don't really know what happens when loading the bookmarks, > because konqueror startup isn't affected and also the unpatched rekonq. > > what do you think about the patch? shall I continue on it? > > regards, > mathias > > > [1] http://bugs.kde.org/show_bug.cgi?id=237390 > _______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
