> On 2010-10-20 12:54:42, Benjamin Poulain wrote: > > src/urlbar/listitem.cpp, line 220 > > <http://git.reviewboard.kde.org/r/100091/diff/3/?file=1565#file1565line220> > > > > Please add spaces before and after the equal character. > > > > And no space after the parenthesis (after ++i). > > > > Damn it ;)
Oh, and a space is missing between the for and the parenthesis. :) - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100091/#review143 ----------------------------------------------------------- On 2010-10-20 12:24:12, Pierre Rossi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100091/ > ----------------------------------------------------------- > > (Updated 2010-10-20 12:24:12) > > > Review request for rekonq, Andrea Diamantini and Benjamin Poulain. > > > Summary > ------- > > Apart from the coding style, this patch essentially fixes the highlighting > algorithm. > > I f**ked up the first time and due to an offset here and an offset there, the > last character of a string wouldn't be bold, even if it needed to. > > > Diffs > ----- > > src/tests/listitem_test.cpp 961f4b6 > src/urlbar/listitem.cpp 8b90814 > > Diff: http://git.reviewboard.kde.org/r/100091/diff > > > Testing > ------- > > Typed "ciao" and "test" in the urlbar, as first pointed out by Andrea. > Added this entry to the existing autotest. > > > Thanks, > > Pierre > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
