> On 2010-11-01 15:23:14, Andrea Diamantini wrote: > > Can I ask what's the need for this? > > if you wanna add the "go" button in the urlbar, I fear you forgot it. And I > > think it can be better to implement it locally in the urlbar. > > If there is another goal, sorry. I cannot see it :( > > Panagiotis Papadopoulos wrote: > I think this is for https://bugs.kde.org/show_bug.cgi?id=255521 > > Personally I do not see any use case for this either… We do not really > need this Go button, like e.g. Konqueror does: > > When you type something into the url bar you can easily click on an entry > to “trigger” something, just like the Go button does… > Adding a Go button thus is unnecessary, unlike in Konqueror, where a Go > button surely is needed, since it does not have a advanced url bar like > rekonq does…
I don't say this is completely uneeded (I don't really care). What I'm pointing out is that (if we really wanna merge this new action), I'll prefer adding something like a new right icon in the urlbar, always last on the right, to click to represent it. - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100125/#review256 ----------------------------------------------------------- On 2010-11-01 13:03:33, Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100125/ > ----------------------------------------------------------- > > (Updated 2010-11-01 13:03:33) > > > Review request for rekonq. > > > Summary > ------- > > - A go action is added to the KXMLGUI action collection. > - A minor change in UrlBar > > > This addresses bug 255521. > /show_bug.cgi?id=255521 > > > Diffs > ----- > > src/mainview.h 29162dd > src/mainview.cpp beaf4e2 > src/mainwindow.cpp 7b4cf8a > src/urlbar/urlbar.h 4cdd9d9 > src/urlbar/urlbar.cpp 1f4a036 > > Diff: http://git.reviewboard.kde.org/r/100125/diff > > > Testing > ------- > > It works as expected. > > > Thanks, > > Yoann > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
