> On 2010-11-03 18:03:56, Andrea Diamantini wrote: > > src/bookmarks/bookmarkowner.cpp, line 239 > > <http://git.reviewboard.kde.org/r/100126/diff/1/?file=3066#file3066line239> > > > > uhm... letting this without a parent will probably leak mem using it. > > The same applies in the other occasions you removed it.
I removed the parent because there's a delete at the end of the function that will be called a lot sooner than the activeWindow's destructor. > On 2010-11-03 18:03:56, Andrea Diamantini wrote: > > src/bookmarks/bookmarkowner.h, line 125 > > <http://git.reviewboard.kde.org/r/100126/diff/1/?file=3065#file3065line125> > > > > You should probably change here the parameter name to bkGroup or > > something like that. Good point :) - Jon Ander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100126/#review276 ----------------------------------------------------------- On 2010-11-01 16:34:59, Jon Ander Peñalba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100126/ > ----------------------------------------------------------- > > (Updated 2010-11-01 16:34:59) > > > Review request for rekonq and Yoann Laissus. > > > Summary > ------- > > I've done some clean-up to the bookmark API. > There are still some things I want to improve, I hope to work on it soon, but > I've been busier than expected lately. > > This diff is more than one commit, if you want to see each commit look at my > personal clone: > http://gitorious.org/~Jonan/rekonq/jonans-mainline/commits/bookmark > > > Diffs > ----- > > src/bookmarks/bookmarkowner.h 573e4ee > src/bookmarks/bookmarkowner.cpp 77af9b1 > src/bookmarks/bookmarkprovider.cpp ccdc326 > src/bookmarks/bookmarkscontextmenu.h d669eef > src/bookmarks/bookmarkscontextmenu.cpp 93df6ce > src/bookmarks/bookmarkspanel.h f042d4c > src/bookmarks/bookmarkspanel.cpp f732cb2 > src/bookmarks/bookmarkstoolbar.cpp 4449d92 > src/history/historypanel.h 0a5ae21 > src/history/historypanel.cpp 28f7f4e > src/urlpanel.h 722eeae > src/urlpanel.cpp b3e8b2f > > Diff: http://git.reviewboard.kde.org/r/100126/diff > > > Testing > ------- > > > Thanks, > > Jon Ander > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
