----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100167/#review398 -----------------------------------------------------------
I can confirm it works well. But I'm not really satisfied with this change. In fact I remember we debated a lot about contextual actions. First 2 considerations: 1) the find action is shown also when pointing an image. IMHO, in that case it has to not be shown. 2) with the "view image in a new tab" we reached the sixth action image related!! IMHO it is a bit too much :) I have a suggestion about: why don't you change the "actual" view image action to show it in a new tab as default? - Andrea On 2010-11-24 16:54:44, Nikhil Shantanu Marathe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100167/ > ----------------------------------------------------------- > > (Updated 2010-11-24 16:54:44) > > > Review request for rekonq. > > > Summary > ------- > > This was a Google Code In 2010 task. Context menu improvements are by Furkan > Uzumcu <[email protected]>. They include: > > * Find... and Print... actions in context menu > * Detect URL like selected text and offer to treat it as a URL and open in > new window/tab > * View Image in new Tab > > > Diffs > ----- > > src/mainwindow.h 33fd202 > src/webview.h 9518b74 > src/webview.cpp 7664805 > > Diff: http://git.reviewboard.kde.org/r/100167/diff > > > Testing > ------- > > Tested and works OK. > > > Thanks, > > Nikhil Shantanu > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
