> On 2010-12-06 12:44:25, Benjamin Poulain wrote: > > src/webtab.cpp, line 266 > > <http://git.reviewboard.kde.org/r/100064/diff/3/?file=4700#file4700line266> > > > > You should use url.isRelative(). Building a Url object is relatively > > expensive, you'd better use the one you already have.
true > On 2010-12-06 12:44:25, Benjamin Poulain wrote: > > src/webtab.h, line 87 > > <http://git.reviewboard.kde.org/r/100064/diff/3/?file=4699#file4699line87> > > > > You don't use the arguments in the implementation, why put them? You > > can do connection signal-slots to a slot with less arguments. true > On 2010-12-06 12:44:25, Benjamin Poulain wrote: > > src/webtab.h, line 86 > > <http://git.reviewboard.kde.org/r/100064/diff/3/?file=4699#file4699line86> > > > > The QPoint should be passed as reference to const: > > void showSearchEngine(const QPoint &pos). This is the convention for > > API consistency in Qt. ok > On 2010-12-06 12:44:25, Benjamin Poulain wrote: > > src/webtab.h, line 52 > > <http://git.reviewboard.kde.org/r/100064/diff/3/?file=4699#file4699line52> > > > > You can replace that by forward declaration if you pass the QPoint by > > ref-to-const. ok > On 2010-12-06 12:44:25, Benjamin Poulain wrote: > > src/webtab.h, line 51 > > <http://git.reviewboard.kde.org/r/100064/diff/3/?file=4699#file4699line51> > > > > Why do you need this include here? There is no new call to QWidget in > > the header. true - Lionel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100064/#review456 ----------------------------------------------------------- On 2010-12-05 11:21:27, Lionel Chauvin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100064/ > ----------------------------------------------------------- > > (Updated 2010-12-05 11:21:27) > > > Review request for rekonq. > > > Summary > ------- > > Icon at the right of the urlbar that allows to add an opensearch engine > > > Diffs > ----- > > "a/src/data/recherche_de_vid/303/251os_youtube.xml" PRE-CREATION > "a/src/data/wikip/303/251dia_(fr).xml" PRE-CREATION > src/CMakeLists.txt f0310b4 > src/application.cpp 95aa9cf > src/data/7digitalcom.xml PRE-CREATION > src/data/CMakeLists.txt 5f49994 > src/data/beolingus.xml PRE-CREATION > src/data/bliptv.xml PRE-CREATION > src/data/bugzilla.xml PRE-CREATION > src/data/citeseerx.xml PRE-CREATION > src/data/cpan_search.xml PRE-CREATION > src/data/de-en_beolingus.xml PRE-CREATION > src/data/dictfr.xml PRE-CREATION > src/data/duck_duck_go.xml PRE-CREATION > src/data/ecosia.xml PRE-CREATION > src/data/facebook.xml PRE-CREATION > src/data/flickr.xml PRE-CREATION > src/data/github.xml PRE-CREATION > src/data/identica_people_search.xml PRE-CREATION > src/data/kde_techbase.xml PRE-CREATION > src/data/kde_techbase_(en).xml PRE-CREATION > src/data/kde_userbase.xml PRE-CREATION > src/data/kde_userbase_(en).xml PRE-CREATION > src/data/leo_deu-eng.xml PRE-CREATION > src/data/leo_deu-fra.xml PRE-CREATION > src/data/portail_lexical_-_cnrtl.xml PRE-CREATION > src/data/urban_dictionary.xml PRE-CREATION > src/data/voila.xml PRE-CREATION > src/data/wikia.xml PRE-CREATION > src/data/wikia_(en).xml PRE-CREATION > src/data/wikipedia.xml 4e15208 > src/data/wiktionary.xml PRE-CREATION > src/data/wiktionary_(en).xml PRE-CREATION > src/data/wolfram_alpha.xml PRE-CREATION > src/data/wr_english-french.xml PRE-CREATION > src/data/wr_english-italian.xml PRE-CREATION > src/data/wr_english-spanish.xml PRE-CREATION > src/data/wr_english.xml PRE-CREATION > src/data/wr_french-english.xml PRE-CREATION > src/data/wr_italian-english.xml PRE-CREATION > src/data/wr_spanish-english.xml PRE-CREATION > src/data/yippy.xml PRE-CREATION > src/mainwindow.cpp c9863f0 > src/opensearch/opensearchengine.cpp 9d5e866 > src/opensearch/opensearchmanager.h 4f42b4a > src/opensearch/opensearchmanager.cpp e5afc14 > src/opensearch/suggestionparser.cpp 4ed13e1 > src/settings/generalwidget.cpp 642813a > src/settings/settingsdialog.cpp a3b4f97 > src/urlbar/listitem.h f5f1153 > src/urlbar/listitem.cpp f29a0e9 > src/urlbar/urlbar.h 67a693c > src/urlbar/urlbar.cpp 1f4a036 > src/urlbar/urlresolver.cpp 57d6ca6 > src/urlbar/webshortcutwidget.h PRE-CREATION > src/urlbar/webshortcutwidget.cpp PRE-CREATION > src/webtab.h 12f528d > src/webtab.cpp bac73fe > > Diff: http://git.reviewboard.kde.org/r/100064/diff > > > Testing > ------- > > > Thanks, > > Lionel > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
