----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100201/#review496 -----------------------------------------------------------
Coding style everywhere: indent with spaces, not tab. Also remove the tab on empty lines you added. src/webview.cpp <http://git.reviewboard.kde.org/r/100201/#comment384> This is incorrect. There is no slot mousePressEvent. src/webview.cpp <http://git.reviewboard.kde.org/r/100201/#comment382> Coding style: no brackets in this case. src/webview.cpp <http://git.reviewboard.kde.org/r/100201/#comment383> Coding style: no brackets for single line if(). Mostly style problems, and the connect() is suspicious. - Benjamin On 2010-12-10 16:41:27, Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100201/ > ----------------------------------------------------------- > > (Updated 2010-12-10 16:41:27) > > > Review request for rekonq. > > > Summary > ------- > > Use Ctrl+Left Click to open a link in a new focused tab, even when the option > "Open tabs in background" is enabled. > > > Diffs > ----- > > src/webview.cpp e90b8da > > Diff: http://git.reviewboard.kde.org/r/100201/diff > > > Testing > ------- > > Tested by me and Panagiotis Papadopoulos and it works ok. > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
