> On 2010-12-12 21:29:15, Pierre Rossi wrote: > > As per Benjamin's comment, I think it'd make the review process easier if > > you left out the xml files for now, especially if we come up with another > > way of shipping those files with rekonq than checking them in the git repo > > (and if we do, they could fit in a separate commit with a quicker review I > > believe). > > > >
I am not sure it is a good idea to separate them: it is a matter of consistency with other features. I loaded all webshortcut's pages, I checked the one that provide an opensearch description file, I added an entry for them in the db_opensearch.json file, I saved the opensearch description file when it provides suggestions. If you remove an xml file but keep the entry in db_opensearch.json then the user can't obtain suggestions because the icon will not appear. If you remove the xml and the entry in db_opensearch.json then the icon will be displayed, the user can download the xml file, add the entry in db_opensearch.json but a new webshortcut will be added => two webshortcuts for the same engine. - Lionel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100064/#review503 ----------------------------------------------------------- On 2010-12-12 20:05:44, Lionel Chauvin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100064/ > ----------------------------------------------------------- > > (Updated 2010-12-12 20:05:44) > > > Review request for rekonq. > > > Summary > ------- > > Icon at the right of the urlbar that allows to add an opensearch engine > > > Diffs > ----- > > src/CMakeLists.txt f0310b4 > src/application.cpp 95aa9cf > src/data/CMakeLists.txt 5f49994 > src/data/beolingus.xml PRE-CREATION > src/data/db_opensearch.json PRE-CREATION > src/data/de2en.xml PRE-CREATION > src/data/dictfr.xml PRE-CREATION > src/data/facebook.xml PRE-CREATION > src/data/kde_techbase.xml PRE-CREATION > src/data/kde_userbase.xml PRE-CREATION > src/data/voila.xml PRE-CREATION > src/data/wikia.xml PRE-CREATION > src/data/wikipedia.xml 4e15208 > src/data/wiktionary.xml PRE-CREATION > src/data/wr_english.xml PRE-CREATION > src/data/youtube.xml PRE-CREATION > src/mainwindow.cpp c9863f0 > src/opensearch/opensearchengine.cpp 9d5e866 > src/opensearch/opensearchmanager.h 4f42b4a > src/opensearch/opensearchmanager.cpp e5afc14 > src/opensearch/suggestionparser.cpp 4ed13e1 > src/settings/generalwidget.cpp 642813a > src/settings/settingsdialog.cpp a3b4f97 > src/urlbar/listitem.h f5f1153 > src/urlbar/listitem.cpp f29a0e9 > src/urlbar/urlbar.h 67a693c > src/urlbar/urlbar.cpp 1f4a036 > src/urlbar/urlresolver.cpp 57d6ca6 > src/urlbar/webshortcutwidget.h PRE-CREATION > src/urlbar/webshortcutwidget.cpp PRE-CREATION > src/webtab.h 12f528d > src/webtab.cpp bac73fe > > Diff: http://git.reviewboard.kde.org/r/100064/diff > > > Testing > ------- > > > Thanks, > > Lionel > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
