----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100205/#review522 -----------------------------------------------------------
I think there are a few minor glitches left, thanks for the good work and great spirit so far. src/webview.cpp <http://git.reviewboard.kde.org/r/100205/#comment413> Why not simply urlLikeText.isValid() ? src/webview.cpp <http://git.reviewboard.kde.org/r/100205/#comment412> I think Benjamin mentioned this one could go inside the if() statement earlier. src/webview.cpp <http://git.reviewboard.kde.org/r/100205/#comment415> using one action pointer a does not really help readability. How about this instead: QAction * const openInNewTabAction = ... and the same for openInNewWindowAction. src/webview.cpp <http://git.reviewboard.kde.org/r/100205/#comment414> a->setData(urlLikeText) ? http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKUrl.html - Pierre On 2010-12-13 12:55:29, Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100205/ > ----------------------------------------------------------- > > (Updated 2010-12-13 12:55:29) > > > Review request for rekonq. > > > Summary > ------- > > * Find action > * Print action > * Open URL-like text in new tab/window > > > Diffs > ----- > > src/webview.cpp e90b8da > > Diff: http://git.reviewboard.kde.org/r/100205/diff > > > Testing > ------- > > Tested and works! > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
